[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Fix issue #2305 - 'svn info' on symlink working copy root fails

From: Alexander Thomas <alexander_at_collab.net>
Date: 2006-01-08 15:56:33 CET

On Fri, 2006-01-06 at 22:39 +0000, Philip Martin wrote:
> Alexander Thomas <alexander@collab.net> writes:
>
> > --- subversion/libsvn_wc/lock.c (revision 17993)
> > +++ subversion/libsvn_wc/lock.c (working copy)
> > @@ -681,7 +681,23 @@
> > int wc_format;
> >
> > SVN_ERR (probe (&dir, path, &wc_format, pool));
> >

[...]
>
> > + err = svn_wc_adm_open3 (&wc_adm, associated, path, FALSE,
> > + 0, cancel_func, cancel_baton, pool);

[...]

> I don't like that -- calling svn_wc_adm_open3 in order ro work out how
> to call svn_wc_adm_open3 just seems wrong. Can't you make probe()
> handle the symlink?

In version 1 of this patch, I tried replacing svn_io_check_path() with
svn_io_check_resolved_path() to handle symlinks in probe(). But it
caused test special_tests.py (1) to fail.
http://svn.haxx.se/dev/archive-2005-10/0559.shtml

IMHO info on root wc symlink should be considered as a special case.

-AT
Received on Sun Jan 8 15:58:42 2006

This is an archived mail posted to the Subversion Dev mailing list.