[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix issue #2305 - 'svn info' on symlink working copy root fails

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-01-06 23:39:25 CET

Alexander Thomas <alexander@collab.net> writes:

> --- subversion/libsvn_wc/lock.c (revision 17993)
> +++ subversion/libsvn_wc/lock.c (working copy)
> @@ -681,7 +681,23 @@
> int wc_format;
>
> SVN_ERR (probe (&dir, path, &wc_format, pool));
> + if (wc_format == 0)
> + {
> + svn_wc_adm_access_t *wc_adm;
>
> + err = svn_wc_adm_open3 (&wc_adm, associated, path, FALSE,
> + 0, cancel_func, cancel_baton, pool);
> + if (!err)
> + {
> + svn_boolean_t wc_root;
> +
> + SVN_ERR (svn_wc_is_wc_root (&wc_root, path, wc_adm, pool));
> + if (wc_root)
> + dir = path;
> + }
> + svn_error_clear (err);
> + }

I don't like that -- calling svn_wc_adm_open3 in order ro work out how
to call svn_wc_adm_open3 just seems wrong. Can't you make probe()
handle the symlink?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 6 23:40:22 2006

This is an archived mail posted to the Subversion Dev mailing list.