[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17326 - trunk/subversion/tests/clients/cmdline

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-11-14 22:58:53 CET

On Mon, 14 Nov 2005, Erik Huelsmann wrote:

> > >>> Log:
> >>> Unmark test for issue #2306 XFAIL.
> >>>
> >>>
> >> the log message should mention the file and symbol that was changed.
> >>
> >
> > It's a one line change. I *really* think that'd make the log message
> > more complex than necessary. I'm sorry I think this is one of those
> > cases where strictness is not a gain.
> >
> It's a one-line change, but it still means one has ti either run "svn
> log -v" or "svn diff" to see where the change was made. You can still
> write a one-line log message that conforms to our coding style.

>Also, isn't that exactly what svn log -v is for?!

It means one has to do extra work when scanning the output of svn log. We
have test cases in core code as well as bindings nowadays.

> It's always been a project policy to be strict on the rules, but in a
> functional way. Having the file name and especially the fact that it
> happened to the symbol test_list doesn't add any *usefull* information

OK, we disagree here. test-list might be redundant, but that's not what
makes the message longer. I personally like the style where everything is
in the log message. I hope you don't think I picked on you just because
you broke some rule.

OK, let's stop this now. We can certainly do more productive things than
arguing about log message style, and we most often do.

Best,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 14 23:03:19 2005

This is an archived mail posted to the Subversion Dev mailing list.