[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17326 - trunk/subversion/tests/clients/cmdline

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-11-14 13:32:28 CET

On Mon, 14 Nov 2005, Erik Huelsmann wrote:

> On 11/14/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Mon, 14 Nov 2005 dionisos@tigris.org wrote:
>
> > Author: dionisos
> > Date: Mon Nov 14 00:59:35 2005
> > New Revision: 17326
> >
> > Modified:
> > trunk/subversion/tests/clients/cmdline/switch_tests.py
> >
> > Log:
> > Unmark test for issue #2306 XFAIL.
> >
> the log message should mention the file and symbol that was changed.

>It's a one line change. I *really* think that'd make the log message
>more complex than necessary. I'm sorry I think this is one of those
>cases where strictness is not a gain.

To me it is not about strictness, it is about readability and ease of
scanning the log messages. Like what Brane said.

Maybe you were in a hurry to get this in to avoid more spurious test
failures. No problem, no harm, of course. :-)

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 14 13:34:05 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.