[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17211 - in branches/wc-propcaching/subversion: libsvn_wc

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-11-14 14:19:07 CET

On Mon, 14 Nov 2005, Ivan Zhakov wrote:

> >svn_wc__merge_prop_diffs(). This should simplify and reduce code.
> I've added a TODO to revisit this before merging to trunk.
> >Because it deprecated and not tested or you missed it?
> Don't ask:-)
>Why? It could be bigger problem: because we have code that never have
>been used, therefore we cannot test it, so any change in such
>deprecated functions dangerous.

I said "Don't ask" because you probably don't want to hear the answer. I
want to get the code that is actually in use in shape first.

You're right that it is a problem that we have code that we don't test.

> Thanks for reviewing,
>You welcome. I haven't time to write much code, sorry.

You know, peer review helps enormously. That's not "doing less" or doing
less worth things than writing code.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 14 14:20:19 2005

This is an archived mail posted to the Subversion Dev mailing list.