[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17211 - in branches/wc-propcaching/subversion: libsvn_wc

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2005-11-14 14:00:37 CET

On 11/14/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Sat, 12 Nov 2005, Ivan Zhakov wrote:
>
> > On 11/6/05, lundblad@tigris.org <lundblad@tigris.org> wrote:
> > Author: lundblad
> > Date: Sat Nov 5 18:44:38 2005
> > New Revision: 17211
> >
> > Modified:
> > branches/wc-propcaching/subversion/include/svn_wc.h
> > branches/wc-propcaching/subversion/libsvn_wc/adm_ops.c
> > branches/wc-propcaching/subversion/libsvn_wc/entries.c
> > branches/wc-propcaching/subversion/libsvn_wc/entries.h
> > branches/wc-propcaching/subversion/libsvn_wc/log.c
> > branches/wc-propcaching/subversion/libsvn_wc/props.c
> > branches/wc-propcaching/subversion/libsvn_wc/props.h
> >
> > Log:
> > On wc-propcaching branch: Add a flag to the entries file keeping track of
> > whether properties were modified or not. Keep this flag updated and
> > use it to determined whether properties are modified. Add lots of TODO
> > markers in the code.
> >
> > NOTE: This commit breaks stat_tests 13, which tests thats certain properties
> > (pun partly intended;) of property timestamps. This has to be resolved.
> >
> > * subversion/include/svn_wc.h (svn_wc_entry_t): Add prop_mods member.
> >
> > * subversion/libsvn_wc/props.c
> > (svn_wc__install_props): New function. Parts factored from
> > svn_wc__merge_props.
> > (svn_wc__merge_props, svn_wc_prop_set2): Use svn_wc__isntall_props.
> >Peter, why you didn't use svn_wc__install_props() in
> >svn_wc__merge_prop_diffs(). This should simplify and reduce code.
>
> I've added a TODO to revisit this before merging to trunk.
>
> >Because it deprecated and not tested or you missed it?
>
> Don't ask:-)
Why? It could be bigger problem: because we have code that never have
been used, therefore we cannot test it, so any change in such
deprecated functions dangerous.

> Thanks for reviewing,
You welcome. I haven't time to write much code, sorry.

--
Ivan Zhakov
Received on Mon Nov 14 14:05:36 2005

This is an archived mail posted to the Subversion Dev mailing list.