[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17211 - in branches/wc-propcaching/subversion: libsvn_wc

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2005-11-14 14:34:57 CET

On 11/14/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Mon, 14 Nov 2005, Ivan Zhakov wrote:
>
> > >svn_wc__merge_prop_diffs(). This should simplify and reduce code.
> >
> > I've added a TODO to revisit this before merging to trunk.
> >
> > >Because it deprecated and not tested or you missed it?
> >
> > Don't ask:-)
> >Why? It could be bigger problem: because we have code that never have
> >been used, therefore we cannot test it, so any change in such
> >deprecated functions dangerous.
>
> I said "Don't ask" because you probably don't want to hear the answer. I
> want to get the code that is actually in use in shape first.
>
> You're right that it is a problem that we have code that we don't test.
In our case, possibly we can implement svn_wc__merge_prop_diffs()
using svn_wc__merge_props() but I cannot test this.

--
Ivan Zhakov
Received on Mon Nov 14 14:41:39 2005

This is an archived mail posted to the Subversion Dev mailing list.