[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [wc-propcaching]: Cached proprety existence, take two

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-11-14 13:47:10 CET

On Sun, 13 Nov 2005, Daniel Berlin wrote:

> On Sat, 2005-11-12 at 14:13 -0500, Daniel Berlin wrote:
> > Peter:
> >
> zhakov pointed out on IRC that both you and I missed a place we need to
> set prop_mods and the new has_properties string.
>
> in revert_admin_things, when entry->schedule == svn_wc_schedule_replace,
> you need to have it reset the prop-mods flags, and i need to have it
> reset the has_properties string.
>
> I've modified the patch to do so, and re-regtested it. So just assume
> that portion is done correctly :)
>

I changed that revert_admin_things to use svn_wc__install_props instead.
It has a flag to avoid writing the base props and we have to load the base
props anyway. Good to have one less place to worry about the details of
property handling.

thanks, Ivan, for detecting this.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 14 13:48:49 2005

This is an archived mail posted to the Subversion Dev mailing list.