[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [wc-propcaching]: Cached proprety existence, take two

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-11-13 18:58:38 CET

On Sat, 2005-11-12 at 14:13 -0500, Daniel Berlin wrote:
> Peter:
> Since the last patch, i have
> 1. Factored out the has_property building into it's own function
> 2. Added the missing calls in revert_admin_things
> 3. Fix svn_wc__get_special to use the prop_get interface, instead of
> doing it on it's own (which lets it use cached properties)
> 4. Made the cached properties function internal to the wc
> implementation.
> 5. Made it return the value of a boolean property if it *does* exist,
> since we know it.
> 6. Changed the separator to '|' in both the cached properties list, and
> the entries has_properties entry.
> 7. Cleaned up a bit .

zhakov pointed out on IRC that both you and I missed a place we need to
set prop_mods and the new has_properties string.

in revert_admin_things, when entry->schedule == svn_wc_schedule_replace,
you need to have it reset the prop-mods flags, and i need to have it
reset the has_properties string.

I've modified the patch to do so, and re-regtested it. So just assume
that portion is done correctly :)

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 13 18:59:38 2005

This is an archived mail posted to the Subversion Dev mailing list.