Re: The cost of svn_io_get_dirents2 and early error messages

On Sun, Nov 13, 2005 at 08:36:17PM -0500, Daniel Berlin wrote:
>...
> *Right now* (IE without any patches), nothing will give you any
> indication that this is an error.
>...
> In fact, diff won't even complain either.

Heh. All right. So even today, we aren't all that rosy :-)

>...
> Actually, with the patch i attached, it will say:
>
> dberlin@linux:/mnt/gccstuff/gcc-dataflow>
> ~/svn-propcaching/subversion/clients/cmdline/svn status config.guess
> svn: Expected config.guess to be a file but found a directory
>
> which is much more informative.

Agreed.

> If you just use status with no command line arguments anything else, it
> will show "~" next to config.guess both now and with the patch
> attached.
>
> However, doing this during updates would, IMHO, be really wrong. We
> don't do it right now, and ideally, the updater wouldn't have to touch
> *anything* that isn't actually updated.

Hmm. All this doesn't make sense, along with Garrett. I think that I
had some notion that it would throw an error during update (useful),
but since it _doesn't_ ... alright.

A while back, we decided to separate the notions of status and update
(unlike CVS which conflates those two). So I think I'd agree with you
guys, and that I was probably conflating the two in my thinking.

Thanks,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org