[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix bogus code in libsvn_client/ra.c: slow_locations()

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-11-08 20:21:25 CET

On 11/8/05, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> Ping.
>
> Does anyone have any comments about this patch? What we have now is
> clearly bogus, and I'm fairly sure the patch is correct, but I'm not
> going to commit without someone else acking it.
>
> (If I don't get any response, I'll just commit a patch that removes the
> useless local variable and makes the code run unconditionally, which is
> what's really happening now).
>
> (Patch is at http://svn.haxx.se/dev/archive-2005-10/1501.shtml, in case
> you've no longer got the original message).

The patch seems reasonable to me, although I didn't go so far as to
commit it myself because I didn't have a good way to test it easily.
What kind of testing have you done with it?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 8 20:23:21 2005

This is an archived mail posted to the Subversion Dev mailing list.