[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix bogus code in libsvn_client/ra.c: slow_locations()

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-11-08 20:42:37 CET

On Tue, Nov 08, 2005 at 11:21:25AM -0800, Garrett Rooney wrote:
> On 11/8/05, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> > Does anyone have any comments about this patch? What we have now is
> > clearly bogus, and I'm fairly sure the patch is correct, but I'm not
> > going to commit without someone else acking it.
> >
> > (If I don't get any response, I'll just commit a patch that removes the
> > useless local variable and makes the code run unconditionally, which is
> > what's really happening now).
> >
> > (Patch is at http://svn.haxx.se/dev/archive-2005-10/1501.shtml, in case
> > you've no longer got the original message).
>
> The patch seems reasonable to me, although I didn't go so far as to
> commit it myself because I didn't have a good way to test it easily.
> What kind of testing have you done with it?
>

I have the same problem as you: no 1.0.x server to test against (does
anyone know of a public one?), so compile-tested and tested-by-inspection
only.

The patch _should_ be safe, since it's just reverting to the behaviour
that we had in 1.2.1, and the changes Greg made in r15581 were mainly
to change the log revisions we requested, not to change the latter part
of the code (as far as I can see from the log message, anyway).

Even so, without any way to exercise the code, I'm not going to commit
it myself without review, however trivial.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 8 20:57:20 2005

This is an archived mail posted to the Subversion Dev mailing list.