Re: [PATCH] mailer.py: truncate_diff_lines feature

On Thu, Nov 03, 2005 at 10:09:30AM -0800, Garrett Rooney wrote:
>...
> I also haven't been paying overly close attention here, but it strikes
> me that some of this may be reinventing the wheel a bit. I believe
> that svnmailer (http://opensource.perlig.de/svnmailer/) already has
> this kind of functionality (splitting diffs across multiple mails,
> excluding them in favor of viewcvs link if they're too long, etc).

Don't you mean that svnmailer is reinventing? Andre decided to fork
rather than contribute his work back to Subversion.

I was very interested in some of the work that Andre did with
svnmailer and went to take a look. Holy crap. There are a lot of
files, a lot of complicating abstractions, and other stuff in there.
I'm certainly biased, but I find mailer.py a lot more workable.

And if people want to contribute improvements back to the core
distribution, then how can that be bad?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org