[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] mailer.py: truncate_diff_lines feature

From: André Malo <nd_at_perlig.de>
Date: 2005-11-07 07:29:55 CET

Well, ehm, perhaps it's time to speak up for me ;-)

* Greg Stein wrote:

> On Thu, Nov 03, 2005 at 10:09:30AM -0800, Garrett Rooney wrote:
> >...
> > I also haven't been paying overly close attention here, but it strikes
> > me that some of this may be reinventing the wheel a bit. I believe
> > that svnmailer (http://opensource.perlig.de/svnmailer/) already has
> > this kind of functionality (splitting diffs across multiple mails,
> > excluding them in favor of viewcvs link if they're too long, etc).
>
> Don't you mean that svnmailer is reinventing? Andre decided to fork
> rather than contribute his work back to Subversion.

The decision has not been made yet (on my side at least). For now I'd
consider it as an external branch.

> I was very interested in some of the work that Andre did with
> svnmailer and went to take a look. Holy crap. There are a lot of
> files, a lot of complicating abstractions, and other stuff in there.
> I'm certainly biased, but I find mailer.py a lot more workable.

That's funny ;-). The main reason to rewrite it from the scratch was, that I
found mailer.py not workable. I simply wanted to extend it for my needs and
found it wasn't that easy, because it's a monolithic block of code which
has to be changed as a whole if you want to extend it. Further it contains
too less documentation and that (not to speak of the bindings which *are*
not pythonic or documented at all, I find myself looking at the subversion
headers and generated C files to figure things out).

Anyway, I know, the notifier modules of svnmailer are a bit messy and I'm
currently refactoring it all (for the 1.1 release). A lot of the base
modules actually belong outside the svnmailer, but it's a bit like shipping
APR with httpd or subversion.

My point is, that the svnmailer is not ready yet to be even considered to be
contributed back. Just wanted to let you know.

nd

-- 
"Das Verhalten von Gates hatte mir bewiesen, dass ich auf ihn und seine
beiden Gefährten nicht zu zählen brauchte" -- Karl May, "Winnetou III"
Im Westen was neues: <http://pub.perlig.de/books.html#apache2>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 7 07:31:02 2005

This is an archived mail posted to the Subversion Dev mailing list.