[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] mailer.py: truncate_diff_lines feature

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-11-03 19:09:30 CET

On 03 Nov 2005 09:55:35 -0600, kfogel@collab.net <kfogel@collab.net> wrote:
> I came into this thread late, sorry.
> It's pointless to include anything less than 100% of a diff. There is
> no way to know whether the most complicated, review-needing part of
> the change is visible or not -- it would just be a roll of the dice
> each time. Instead, just omit diffs that exceed the maximum size,
> replacing them with a "[diff omitted because too large]" message, and
> provide a ViewCVS link (or whatever) for all diffs, both those
> included inline and those omitted.

I also haven't been paying overly close attention here, but it strikes
me that some of this may be reinventing the wheel a bit. I believe
that svnmailer (http://opensource.perlig.de/svnmailer/) already has
this kind of functionality (splitting diffs across multiple mails,
excluding them in favor of viewcvs link if they're too long, etc).


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 3 19:12:27 2005

This is an archived mail posted to the Subversion Dev mailing list.