[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] mailer.py: truncate_diff_lines feature

From: Joseph Galbraith <galb_at_vandyke.com>
Date: 2005-11-02 17:10:57 CET

Alan Barrett wrote:
> On Wed, 02 Nov 2005, C. Michael Pilato wrote:
>> Alan Barrett <apb@cequrux.com> writes:
>>> [[[
>>> Add truncate_diff_lines feature to mailer.py hook script. If this
>>> is set to a non-zero value, then diffs longer than the specified
>>> number of lines will be truncated in email messages.
>> "truncate_diff_lines" sounds like you're chopping characters off the
>> ends of long lines, not chopping lines off the end of a long diff.
>> Suggest "truncate_diff".
>
> Fine.
>
>> I'm somewhat ambivalent about this feature addition, but do have one
>> concern: I'd prefer it if the act of truncating a diff would cause an
>> application of that diff data as a patch to fail in some noticable
>> way. In a sea of 100 diffs in a single email, it'd be really easy to
>> miss a single instance of a truncated one -- what happens to the poor
>> guy that tries to apply that email as a patch and succeeds because the
>> truncation happened to line up with a hunk boundary?
>
> I'll investigate making "patch" fail in a noticeable way.
>
> This feature is intended for use in cases where the email is read by
> people who want to receive a 10-line diff when somebody makes a small
> change, but don't want to receive a 1000-line mail message when somebody
> creates a new 1000-line file, or when somebody makes many changes
> throughout a large file. If you are sending mail to an automated
> process, or to people who will want to treat the mail as a patch to be
> applied, then you shouldn't be using this feature.

Just a confirmation: this would be very useful in our
environment; we don't apply patches from the email,
we use the diffs to increase visibility and get
additional code review.

But a 10000 line diff does not accomplist these goals
because its so big people just delete it instead of
reading it. (We have very few of these and they are
almost always merging changes from trunk to branch.)

Thanks,

Joseph

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 2 17:01:08 2005

This is an archived mail posted to the Subversion Dev mailing list.