[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Sharing libsvn_fs_* internals [was: "Locked" messages useless]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-11-02 16:51:18 CET

Peter N. Lundblad wrote:
> On Wed, 2 Nov 2005, C. Michael Pilato wrote:
>
>>I'm fine with the circular dependency. The error stuff can move into
>>libsvn_fs, as can the svn_fs_*__canonicalize_abspath(). I caution
>>against futzing with anything but such low-hanging fruit.
>
> How would that work on Windows? Currently, we only have a circular
> dependency regarding struct definitions. We can't have it on functions (or
> other symbols). We could do a hack like wrapper_template.h in libsvn_ra,
> but I like to avoid such if possible.

I'll take that as a declaration that circular dependencies at the object code
level are not allowed in our Windows build. That's fine; it's not a good idea
to structure code libraries that way anyway.

So, that's about the end of it as far as I'm concerned. We can move
source-level-only things to libsvn_fs, but I don't see any of those at the
moment. Anything more drastic, given the rest of the comments in this thread,
I'm not going to consider.

Thanks for the discussion.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 2 16:52:43 2005

This is an archived mail posted to the Subversion Dev mailing list.