[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] mailer.py: truncate_diff_lines feature

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-11-03 03:10:00 CET

Alan Barrett wrote:
> This feature is intended for use in cases where the email is read by
> people who want to receive a 10-line diff when somebody makes a small
> change, but don't want to receive a 1000-line mail message when somebody
> creates a new 1000-line file, or when somebody makes many changes
> throughout a large file. If you are sending mail to an automated
> process, or to people who will want to treat the mail as a patch to be
> applied, then you shouldn't be using this feature.
In that case, I suggest defining some maximum diff size, and if the diff
exceeds that size to not in include it in the mail at all. Just add a
note, e.g. "Diff ommitted, because it's longer than N lines.

Truncating the diff at some arbitrary length is totally wrong because
it's a) lying to the user, and b) produces a patch that has nothing to
do with the actual change. Better to simply say that there's no diff,
and let people do the necessary "svn diff" themselves.

IIRC the mailer can produce ViewCVS diff links, so including that link
(if so configured) would be a nice shortcut.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 3 03:08:35 2005

This is an archived mail posted to the Subversion Dev mailing list.