[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "Locked" messages useless

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-11-02 09:11:26 CET

On Tue, 1 Nov 2005, Julian Foad wrote:

> Greg Hudson wrote:
> > On Sun, 2005-10-16 at 16:43 +0100, Philip Martin wrote:
> >
> > I'd say that this error message should not be using the filesystem
> > location in the first place.
>
> I think I agree. Callers, at least up to the level of svn_repos_fs_lock(),
> know what filesystem they are accessing, so if they want to add this
> information to any error that is returned, they can.
>
+1.

> (While we're on the subject, shouldn't those two "err.c" files be unified,
> given that only about 2 of the 25 functions differ at all between them?)
>
The question is *where* this file should go. libsvn_subr doesn't seem
right. Do we want a libsvn_fs_util just for this? (I think this has been
discussed before.)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 2 09:12:39 2005

This is an archived mail posted to the Subversion Dev mailing list.