[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "Locked" messages useless

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-11-01 23:41:36 CET

Greg Hudson wrote:
> On Sun, 2005-10-16 at 16:43 +0100, Philip Martin wrote:
>
>>>svn: Path '/trunk/sprints/Sprints.mdb' is already locked by user 'iar'
>>>in filesystem 'C:/Daten/svnroot/myrepo/db'
>
>>When using http:// the repository location will get stripped from the
>>error message as a security measure. Perhaps svnserve should be doing
>>the same?
>
> I'd say that this error message should not be using the filesystem
> location in the first place.

I think I agree. Callers, at least up to the level of svn_repos_fs_lock(),
know what filesystem they are accessing, so if they want to add this
information to any error that is returned, they can.

So, I vote for removing the path to the repository filesystem from all of the
error messages in subversion/libsvn_fs_{base,fs}/err.c

Opinions?

(While we're on the subject, shouldn't those two "err.c" files be unified,
given that only about 2 of the 25 functions differ at all between them?)

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 1 23:49:31 2005

This is an archived mail posted to the Subversion Dev mailing list.