[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ViewCVS broken for r17006

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-10-27 19:05:58 CEST

On Thu, Oct 27, 2005 at 11:29:05AM -0400, C. Michael Pilato wrote:
> > svn_string_t (which svn_fs_txn_prop() [et al] uses) are counted strings.
> > I wondered if this is due to the difference between a property containing
> > "2005-10-25T14:52:07.936032Z" (r17005) and one containing something like
> > "2005-10-25T15:33:29.047905Z\0" (r17006). Of course, I've no way to
> > test that theory, since for all I know, ra_dav strips out everything
> > following a NUL byte.
> Yeah, I thought this might be the possibility, but 'svn pget --strict'
> reveals no trailing NUL.

The '--strict' option just prevents the terminating newline from being
output by the client, nothing else.

In any case, any NUL characters in the property value _would_ be stripped
out, since svn_cl__propget() calls svn_subst_detranslate_string()
to convert the property contents to local EOL style and code page
[because it's an 'svn:' property, and those properties are assumed
to be in UTF-8 with NL line-terminators] - and _that_ procedure
would be better named svn_subst_detranslate_cstring(), since it calls
svn_subst_translate_cstring2() to do the actual translation, stripping
out anything following a NUL.

> (And besides, why would we suddenly start
> seeing trailing NULs in one revision's datestamp and not others?)

Because _that_ revision was committed by the EBCDIC guys, and I'm
immediately suspicious of anything their weird non-ASCII clients might be

Just kidding. I've no idea why this particular revision might be
causing trouble; the embedded NUL byte idea above is based solely on the
(truncated) message coming out of ViewCVS - "svn_time_from_cstring()
argument 1 must be string without null bytes, not str...".


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 27 19:07:42 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.