Re: [PATCH]: Trying to get rid of iconv dependency on windows

On Thu, Oct 13, 2005 at 05:27:55PM +0200, Stefan Küng wrote:
> >One quick question: If I remember correctly, the Win32 functions will fill
> >up an output buffer completely if the buffer is too small, without a null
> >terminator. I'm not familiar with the APR functions - do they do the same?
>
> The behaviour if the function fails is undefined, i.e. the content of
> the output buffer. But I don't see a problem: if the function fails, the
> output isn't used anyway.

Ok, I see that now (it wasn't clear by just looking at the diff). I was
confused by 'return success and set *outbytes_left to zero' being the
(undocumented, as far as I can see) return condition that indicated that
the output buffer wasn't large enough. I was also a little confused by
the names of the formal parameters.

But I see you inherited both of those from APR anyway.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 14 16:47:00 2005