[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Trying to get rid of iconv dependency on windows

From: Stefan KŁng <tortoisesvn_at_gmail.com>
Date: 2005-10-13 17:27:55 CEST

Malcolm Rowe wrote:
> On Wed, Oct 12, 2005 at 09:18:42PM +0200, Stefan KŁng wrote:
>
>>And I don't think it's an argument to prevent this patch from going in,
>>if you can't even tell under *what* circumstances these functions are
>>broken.
>>
>
>
> You're right, sorry, that was a pretty pointless post, wasn't it? (I
> blame the cold I've got at the moment).
>
> One quick question: If I remember correctly, the Win32 functions will fill
> up an output buffer completely if the buffer is too small, without a null
> terminator. I'm not familiar with the APR functions - do they do the same?

The behaviour if the function fails is undefined, i.e. the content of
the output buffer. But I don't see a problem: if the function fails, the
output isn't used anyway.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 13 17:29:03 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.