[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add necessary copy constructors to libsvn_subr, libsvn_delta (1.3.x, Issue #2172)

From: David James <james82_at_gmail.com>
Date: 2005-09-30 07:37:20 CEST

On 9/28/05, Branko ╚ibej <brane@xbc.nu> wrote:
> Julian Foad wrote:
>
> >> +svn_txdelta_window_t *svn_txdelta_window_dup (
> >> + const svn_txdelta_window_t *window, apr_pool_t *pool);
> >
> >
> > This would be better if you start the function name on a new line, as
> > we often do especially when the return type is long, like this:
> >
> > svn_txdelta_window_t *
> > svn_txdelta_window_dup (const svn_txdelta_window_t *window,
> > apr_pool_t *pool);
>
> No, we don't. We have the return type and function name on the same line
> in headers, and on separate lines in implementation files. Always.
Thanks for clearing this up. Okay, I'll keep the return type and
function name on the same line.

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james
Received on Fri Sep 30 07:38:12 2005

This is an archived mail posted to the Subversion Dev mailing list.