Re: [PATCH] Add necessary copy constructors to libsvn_subr, libsvn_delta (1.3.x, Issue #2172)

Julian Foad wrote:

>> +svn_txdelta_window_t *svn_txdelta_window_dup (
>> + const svn_txdelta_window_t *window, apr_pool_t *pool);
>
>
> This would be better if you start the function name on a new line, as
> we often do especially when the return type is long, like this:
>
> svn_txdelta_window_t *
> svn_txdelta_window_dup (const svn_txdelta_window_t *window,
> apr_pool_t *pool);

No, we don't. We have the return type and function name on the same line
in headers, and on separate lines in implementation files. Always.

>> + svn_auth_ssl_server_cert_info_t *new_info =
>> + apr_palloc (pool, sizeof (*new_info));
>
>
> We tend not to leave an operator (like "=" or "+") on the end of a
> line; move it to the beginning of the next line (indented by two
> spaces). (Here and in two more places.)

Well actually we do leave "=" at the end of the previous line.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 29 01:32:04 2005