Re: [PATCH] Add necessary copy constructors to libsvn_subr, libsvn_delta (1.3.x, Issue #2172)

Branko Èibej <brane@xbc.nu> writes:

> Julian Foad wrote:
>
>>> +svn_txdelta_window_t *svn_txdelta_window_dup (
>>> + const svn_txdelta_window_t *window, apr_pool_t *pool);
>>
>> This would be better if you start the function name on a new line,
>> as we often do especially when the return type is long, like this:
>>
>> svn_txdelta_window_t *
>> svn_txdelta_window_dup (const svn_txdelta_window_t *window,
>> apr_pool_t *pool);
>
> No, we don't. We have the return type and function name on the same
> line in headers, and on separate lines in implementation files. Always.

That's not true, most header files have a mixture of both styles and
svn_delta.h is no exception.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org