[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add necessary copy constructors to libsvn_subr, libsvn_delta (1.3.x, Issue #2172)

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-09-30 20:44:22 CEST

Branko Èibej <brane@xbc.nu> writes:

> Julian Foad wrote:
>
>>> +svn_txdelta_window_t *svn_txdelta_window_dup (
>>> + const svn_txdelta_window_t *window, apr_pool_t *pool);
>>
>> This would be better if you start the function name on a new line,
>> as we often do especially when the return type is long, like this:
>>
>> svn_txdelta_window_t *
>> svn_txdelta_window_dup (const svn_txdelta_window_t *window,
>> apr_pool_t *pool);
>
> No, we don't. We have the return type and function name on the same
> line in headers, and on separate lines in implementation files. Always.

That's not true, most header files have a mixture of both styles and
svn_delta.h is no exception.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 30 20:45:24 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.