[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.3 now blocking on path escaping in httpd operational logging

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2005-09-27 17:29:21 CEST

On Tue, Sep 27, 2005 at 11:01:12AM -0400, C. Michael Pilato wrote:
> Justin Erenkrantz <justin@erenkrantz.com> writes:
>
> > > XML-escaping permits whitespace, meaning whitespace could not be our
> > > delimiter. And mixing encodings is nasty.
> >
> > No, it doesn't. Those would still be quoted by virtue of the log format
> > string that the admin would set.
>
> I'm ... not able to parse that. Sorry, Justin.

The log format that the admin would use would look like (from Ben's
initial email):

CustomLog logs/svnlog "%t %u \"%{SVN-ACTION}e\"" env=SVN-ACTION

An instance would look like (again, from Ben's email):

[29/Aug/2005:18:09:48 -0500] powerguy "changed value of revision property 'svn:log'"

(%t == time stamp; %u == user)

The 'escaped' quotes in the admin's format string would be real quotes
in the log. However, by virtue of httpd's escape mechanisms, no quotes
from the passed-in value (or any high-bit 8-bit chars, etc.) would make
it through to the logs un-escaped.

Therefore, a white space isn't required to parse the log format.
Whitespace could be helpful for parsing the SVN-ACTION parameter - but
it would be just as trivial to indicate that any 'action values' related
to property names are XML-encoded.

Hope this clarifies things a bit. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 27 17:36:41 2005

This is an archived mail posted to the Subversion Dev mailing list.