[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.3 now blocking on path escaping in httpd operational logging

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-09-27 17:01:12 CEST

Justin Erenkrantz <justin@erenkrantz.com> writes:

> > XML-escaping permits whitespace, meaning whitespace could not be our
> > delimiter. And mixing encodings is nasty.
>
> No, it doesn't. Those would still be quoted by virtue of the log format
> string that the admin would set.

I'm ... not able to parse that. Sorry, Justin.

> > After sleeping on this, I'd like to reverse my position. I'm fine
> > with double-quote-wrapped, single-space-delimited, backslash-escaped,
> > UTF-8 output:
> >
> > "propset" "svn:log" "This is my first \"real\" propset."
> > "checkout" "/trunk/My Documents/Miscellany"
> > ...
>
> httpd forbids high-bit 8-bit characters.

Ah! I missed this part of the discussion, obviously.

> Here are the rules for logging within httpd (see gen_test_char.c):
>
> /* For logging, escape all control characters,
> * double quotes (because they delimit the request in the log
> * file)
> * backslashes (because we use backslash for escaping)
> * and 8-bit chars with the high bit set
> */
>
> As I was trying to make clear in IRC yesterday, UTF-8 isn't an option.
> httpd (via ap_escape_logitem function) will convert the high-bit values
> via the c2x() function - which will print the hex value anyway
> (%xx).

Gotcha. And, ick. And, ugh. And, yuck.

Then I must present my position reversal reversal petition, whereby I
petition to reverse the reversal of my position. I'll follow with my
updated position proposition, in which I propose that after reversing
the reversal of my position, my position is now undefined.

I need a physician.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 27 17:03:48 2005

This is an archived mail posted to the Subversion Dev mailing list.