[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Symlink handling in svn status broken

From: Phillip Susi <psusi_at_cfl.rr.com>
Date: 2005-09-22 18:28:03 CEST

Philip Martin wrote:

>
> Obvious to whom? Perhaps symlinks should be neither svn_node_file or
> svn_node_directory.
>

Well, obvious to me of course. It seemed to me that the code set
another 'special' flag to indicate that the node is a link, and the
other type field to svn_node_file so that it is treated like a file by
the rest of the system that doesn't care if it is a link or not. It
would be analogous then to set the special flag and svn_node_dir if the
link is in fact, to a directory. Of course, I'm no expert on the code,
which is why I ask that someone who knows better take a look and decide.

>
> Have you tried it recently? I can't reproduce with trunk on Linux.
>
> $ svn st -v branches trunk
> 2 1 pm branches
> 2 1 pm trunk
>

What did you do to reproduce it? If you checkout a repository to the
directory trunk, then enter trunk where a subdir 'subdir' is contained,
then move subdir elsewhere and replace it with a symbolic link to the
new location of subdir, when you do an svn st from the trunk directory,
it should complain.

As far as I could see from reading the source, it complains because the
node that represents subdir is flagged as svn_node_file instead of
svn_node_dir, yet the entries file says subdir is a directory, so you
get an error message because subversion thinks subdir is a file when it
should be a directory.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 22 18:29:16 2005

This is an archived mail posted to the Subversion Dev mailing list.