[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Was: Enhancement needed in svn status -u

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-09-22 18:30:55 CEST

Philip Martin <philip@codematters.co.uk> writes:

> > @@ -1276,6 +1309,33 @@
> > }
> >
> >
> > +/* Copy out of date info from dir_baton or file_baton
> > + to svn_wc_status2 structure. */
> > +static void
> > +copy_ood_info(void *baton, svn_wc_status2_t *status, svn_boolean_t is_dir)
> > +{
> > + if (baton && status)
> > + if (is_dir)
> > + {
>
> The indentation doesn't follow the Subversion style guidelines.

Also doesn't follow the space-before-paren convention. Personally,
I'm all about early returns to avoid excess indentation, so I'd
recommend:

   static void
   copy_ood_info (void *baton, svn_wc_status2_t *status, svn_boolean_t is_dir)
   {
     if (! (baton && status))
       return;
     if (is_dir)
       {

(and then un-indent that 'else' clause later by two spaces)

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 22 18:32:07 2005

This is an archived mail posted to the Subversion Dev mailing list.