[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Symlink handling in svn status broken

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-09-22 17:56:32 CEST

Phillip Susi <psusi@cfl.rr.com> writes:

> Thought I would try to draw some attention to this again, as it has
> been another few months.
>
> It seems like such a simple bug with a simple fix.

Changing code right in the middle of the io library is never simple.

> The code sets a
> variable in a structure to indicate that the object is a file if
> apr_stat says it is a file, or a directory if apr_stat says it is a
> directory, but if apr_stat says it is a link, the code assumes it is a
> file and sets the object type to file. It seems obvious that it needs
> to check if the link is to a directory, and if so, set the type to
> directory, not file.

Obvious to whom? Perhaps symlinks should be neither svn_node_file or
svn_node_directory.

>
> Could someone take a look at this one?

>>> reported as #2284
>>> (http://subversion.tigris.org/issues/show_bug.cgi?id=2284)

Have you tried it recently? I can't reproduce with trunk on Linux.

$ svn st -v branches trunk
                2 1 pm branches
                2 1 pm trunk

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 22 17:57:27 2005

This is an archived mail posted to the Subversion Dev mailing list.