Re: [patch] l10n crashes

Branko Čibej wrote:
> Peter Samuelson wrote:
>
>> The crash fixed in r15880 is not specific to pl.po. The same error, in
>> the same place, occurs in 3 other translations. This is true in both
>> trunk and 1.2.x.
>>
>> [[
>> Fix a crash due to an incorrect format string, in assorted po files.
>>
>> * subversion/po/it.po, subversion/po/pt_BR.po, subversion/po/zh_TW.po:
>> Fix a format string.
>> ]]
>>
>>
> Hm!
>
> I thought the gettext tools could verify that the format strings in the
> translated messages are correct? If they can, we should do this checking
> in a post-commit hook.

The problem is that they only check strings which xgettext has heuristically
determined to be format strings.

One major category which is not getting checked properly is:

  some_printf_like_function (_("Just a plain string with no format
characters));

Now, if a translation accidentally adds a % code, .... CRASH.

Not sure how best we can solve this.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 3 19:11:34 2005