Re: [PATCH] Avoid swig.exe warnings on Unix release builds

On 8/29/05, Branko Èibej <brane@xbc.nu> wrote:> David James wrote:> > >[[[> >> >Avoid swig.exe warnings on Unix release builds. Followup to r15944.> >> >* build/generator/gen_win.py> > (GeneratorWin.__init__): Change "swig.exe" to "swig", so that we can> > call swig portably from both Windows and Unix.> >> >]]]> >> >> >Index: gen_win.py> >===================================================================> >--- gen_win.py (revision 15951)> >+++ gen_win.py (working copy)> >@@ -812,9 +812,9 @@> > libdir = ''> >> > if self.swig_path is not None:> >- self.swig_exe = os.path.join(self.swig_path, 'swig.exe')> >+ self.swig_exe = os.path.join(self.swig_path, 'swig')> >> >> What's the point? If you configure --with-swig, that path gets embedded> in the .pdb/.vcproj files, so if you generate those on Unix, they'll> most likely not work on Windows where you have to build the stuff. So,> when building a Windows release tarball (zipball?), you can't use> --with-swig (or any of the other --with options
, for that matter).
I don't think there will be any Unix users who will use the--with-swig flag. But, since it is easy to make your code moreportable, why not fix it? It is more consistent anyway.
> > else:> >- self.swig_exe = 'swig.exe'> >+ self.swig_exe = 'swig'
Without this fix, "./autogen.sh --release" fails on Unix.
Cheers,
David
-- David James -- http://www.cs.toronto.edu/~james
Received on Mon Aug 29 20:55:27 2005