Re: svn commit: r15948 - in trunk/subversion: libsvn_client libsvn_ra libsvn_ra_dav libsvn_ra_local libsvn_ra_svn

Peter N. Lundblad wrote:

>>Something like
>>/** Similar to svn_ra_callbacks2_t, except that the progress
>> * notification function and baton is missing.
>> *
>> * @deprecated Provided for backward compatibility with the 1.2 API.
>> */
>>
>
> Yeah, or even
> "Similar to @c svn_ra_callbacks2_t, except that @c progress_func and @c
> progress_baton are not present". The important difference is that the
> members are referred directly by their names instead of inventing a new
> term.

In the patch I've sent, I have used my suggestion above. Maybe I should
have waited a little longer ;)

> And as we've seen this comment can be misunderstood, since I just did
> so:-) When I read it, I interpreted it like "don't change the content of
> that variable" which is exactly what the const keyword tells both the
> reader and the compiler. I would instead say that it is important that
> this variable remains const and why.
>
> Thanks for tracking this commit on the dev@ list. I'll look at your next
> patch.

I've already sent a patch. See my last mail in this thread. With that
patch, that comment is obsolete because to avoid the const-nonconst
stuff I've introduced a new structure private for the neon callback.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org