[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix non interruptable hang in svn client when connecting

From: Phillip Susi <psusi_at_cfl.rr.com>
Date: 2005-08-25 23:52:47 CEST

I don't think that this workaround is really appropriate, as it doesn't
directly take on the cause of the problem. The problems as I see them are:

1) OSX apparently has a bug in its kernel network stack

2) The svn client on win32 is explicitly disabling the console ctrl-c
handler so it can't be killed that way. Terminating the process in task
manager works fine.

3) What the heck is wrong with apr_connect? The call should return
almost immediately assuming the remote host is alive but has nothing
listening on that port. If the remote host is not reachable then the
connect call should return after some reasonable timeout period, which
is usually between 15 and 60 seconds. In the former case it should
indicate that the connection was refused, and in the latter, that the
connection timed out. In both cases, SIGINT/ctrl-c should interrupt and
kill the process, and obviously SIGKILL/TerminateProcess() most
definately should.

kfogel@collab.net wrote:
> Okay, I understand now, thanks to you and Michael Sweet.
>
> Note that I can successfully SIGKILL on Linux, which is expected. I
> suspect this kernel bug in OS X will be fixed eventually.
>
> However, I think I'm going to commit the latest patch. It seems like
> it is an improvement for some people, and at least not harmful for
> everyone else.
>
> Done in r15909.
>
> Thanks!
>
> -Karl
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 25 23:55:04 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.