[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix non interruptable hang in svn client when connecting

From: <kfogel_at_collab.net>
Date: 2005-08-25 23:07:12 CEST

Phillip Susi <psusi@cfl.rr.com> writes:
> I don't think that this workaround is really appropriate, as it
> doesn't directly take on the cause of the problem. The problems as I
> see them are:
>
> 1) OSX apparently has a bug in its kernel network stack
>
> 2) The svn client on win32 is explicitly disabling the console ctrl-c
> handler so it can't be killed that way. Terminating the process in
> task manager works fine.
>
> 3) What the heck is wrong with apr_connect? The call should return
> almost immediately assuming the remote host is alive but has nothing
> listening on that port. If the remote host is not reachable then the
> connect call should return after some reasonable timeout period, which
> is usually between 15 and 60 seconds. In the former case it should
> indicate that the connection was refused, and in the latter, that the
> connection timed out. In both cases, SIGINT/ctrl-c should interrupt
> and kill the process, and obviously SIGKILL/TerminateProcess() most
> definately should.

Another thing that concerns me is that Ben Collins-Sussman, on his Mac
notebook (OS X 10.4, Darwin kernel 8.2.0), couldn't reproduce most of
this bug. He ran

   $ svn co http://svn.edgewall.com

It hung, of course. He tried Ctrl-C several times, and it didn't
respond. But when we finally did "kill -9 PID", that killed it.
There seem to be no ill effects on the network stack from that.

So yeah, I'm really wondering if r15909 was a good idea. I don't want
to hastily revert it, but it's not clear that it's doing a whole lot
of good. If it really has the effect that I thought it had, then it
would be good, but so far that effect seems to only exist on Yun
Zheng's computer. Hmmm.

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 26 00:07:03 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.