Re: swig-rb trunk r15714: FAIL (x86_64-unknown-linux-gnu shared)

Hi David,

Thanks for your report.

In <df2177af0508150844488df845@mail.gmail.com>
  "Re: swig-rb trunk r15714: FAIL (x86_64-unknown-linux-gnu shared)" on Mon, 15 Aug 2005 11:44:38 -0400,
  David James <james82@gmail.com> wrote:

> It looks like the Ruby tests are crashing right now due to segfaults
> in test_transaction.

I posted the codes(*) that fixes the problem. (It looks that
you noticed this patch.) But the patch is not reviewed.

I attach the patch and log message.
{{{
Fix a too cleaning out directory cache bug.

* subversion/libsvn_fs_fs/fs_fs.c
  (svn_fs_fs__abort_txn): Add NULL check.
}}}

Regards,

--
kou
--
(*): http://svn.haxx.se/dev/archive-2005-08/0530.shtml

Index: subversion/libsvn_fs_fs/fs_fs.c
===================================================================
--- subversion/libsvn_fs_fs/fs_fs.c (revision 15732)
+++ subversion/libsvn_fs_fs/fs_fs.c (working copy)
@@ -2713,8 +2713,11 @@
 
   /* Clean out the directory cache. */
   ffd = txn->fs->fsap_data;
- svn_pool_clear (ffd->dir_cache_pool);
- ffd->dir_cache_id = NULL;
+ if (ffd->dir_cache_id)
+ {
+ svn_pool_clear (ffd->dir_cache_pool);
+ ffd->dir_cache_id = NULL;
+ }
 
   /* Now, purge the transaction. */
   SVN_ERR_W (svn_fs_fs__purge_txn (txn->fs, txn->id, pool),

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 16 07:58:51 2005