Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

It's better, then nothing.
Greg Hudson wrote:
> There's another, admittedly more subtle way of looking at this:
>
> * The log message is a sequence of lines.

Okey, why not. Much more code will be rewriten. But you'll get your
favorite format of log messages.

May be other svn properties must be considered as a sequence of lines also?

> * The svn:log property gives the log message, with the exception that
> if svn:log does not end in a newline, then it is ever so slightly
> corrupt. In this case, "svn log" will correct for that (the log message
> becomes the svn:log property plus a newline) because historically, we
> haven't enforced that constraint.

As I can undestand at current moment "svn log" always add one newline.
New algorithm is better.

> * The client will ensure that svn:log values end in a newline when new
> revisions are committed and when "svn propset" is done. (Will the
> server also enforce this constraint? I'm not sure; how much enforcement
> do we do on other svn: properties?)

Server must enforce this constraint. Or other subversion client will
break it.

> Obviously, I am describing some hypothetical future Subversion, not the
> current one.

If format of log messages as "a sequence of lines" will be standart in
some hypothetical future then no reason guard it now.

>>So the question becomes: is svn log output intended for nice display,
>>or is it intended to allow exact reconstruction of the log message?
>
> In this view, "svn log" gives the exact log message, but not always the
> exact value of the svn:log property. For that you use svn propget
> --revprop --strict svn:log.

In this view "svn log" gives the exact log message except "slightly
corrupted" (without newline). Why do you want give method to get
"slightly corrupted" log messages?

-- 
Olleg Samoylov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org