[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

From: Michael W Thelen <mike_at_pietdepsi.com>
Date: 2005-07-22 19:16:48 CEST

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>>Olleg, I agree with you that the behaviour is odd and unpleasant and
>>seems to be wrong. I also would like the program to remove trailing
>>whitespace, either when creating or when displaying the log message.
> I am totally, completely opposed to Subversion taking the trailing
> newline off my log messages. Take my house, take my car, take my
> piano (well, no, leave the piano please) but DO NOT TAKE my trailing
> newline.
> Thank you :-).

I agree with everything you've said in this message. If the user, via
her editor, has committed a log message with a trailing newline, her
wishes should be respected and the newline should be left alone.

As far as I can tell from this thread, the only real problem is in the
display produced by "svn log". When the log message ends in a newline,
svn log displays one more newline than expected. If that's the problem,
then I think the solution is to modify the svn log code that displays
log messages (solution #2 in Karl's original response to this thread).
Make it only add a newline if the log message doesn't already end in
one. Would that behavior completely solve this problem?

This solution has the advantage of leaving the log message alone, as the
user may have intended it. It will also fix the problem retroactively
for existing log messages that already end in newlines. Anyone with a
newer client would see existing log messages without extra newlines.

If the problem is in displaying log messages, let's fix it in the
display code. I don't believe this needs to wait for 2.0 either, since
we're not really changing the svn log display format. We'd simply be
displaying fewer lines than before, and the "X lines" information would
be updated appropriately.

Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 19:17:57 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.