[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn st -u regression with 1.1.x servers

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-07-18 18:07:43 CEST

On Jul 18, 2005, at 10:07 AM, Erik Huelsmann wrote:

>>> - SVN_ERR( svn_ra_dav__maybe_store_auth_info_after_result(err,
>>> ras) );
>>> + err = svn_ra_dav__maybe_store_auth_info_after_result(err, ras);
>>>
>>> if (baton.err)
>>> return baton.err;
>>>
>>>
>
> If baton.err != NULL, you leak err here if that too is not NULL.

That's already fixed in /trunk, just not in 1.2.x. Take a look.

I agree with lundblad's comment on my commit. We should just make
*all* RA implementations of svn_ra_get_lock return
SVN_ERR_RA_NOT_IMPLMENTED. That's what we do for all the other new
RA functions. I'm working on this now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 18 18:08:40 2005

This is an archived mail posted to the Subversion Dev mailing list.