[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn st -u regression with 1.1.x servers

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-07-18 17:07:36 CEST

> SteveKing wrote:
> > I think I found the reason why it doesn't work anymore. Patch attached.
> > With this patch (and the one Ben Collins-Sussman sent earlier) it works
> > again.
> >
> > Stefan
> >
> >
> > ------------------------------------------------------------------------
> >
> > Index: subversion/libsvn_ra_dav/fetch.c
> > ===================================================================
> > --- subversion/libsvn_ra_dav/fetch.c (Revision 15306)
> > +++ subversion/libsvn_ra_dav/fetch.c (Arbeitskopie)
> > @@ -1578,7 +1578,7 @@
> >
> > /* ### Should svn_ra_dav__parsed_request() take care of storing auth
> > ### info itself? */
> > - SVN_ERR( svn_ra_dav__maybe_store_auth_info_after_result(err, ras) );
> > + err = svn_ra_dav__maybe_store_auth_info_after_result(err, ras);
> >
> > if (baton.err)
> > return baton.err;
> >

If baton.err != NULL, you leak err here if that too is not NULL.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 18 17:08:20 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.