[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn st -u regression with 1.1.x servers

From: <kfogel_at_collab.net>
Date: 2005-07-18 21:24:57 CEST

Erik Huelsmann <ehuels@gmail.com> writes:
> > > ------------------------------------------------------------------------
> > >
> > > Index: subversion/libsvn_ra_dav/fetch.c
> > > ===================================================================
> > > --- subversion/libsvn_ra_dav/fetch.c (Revision 15306)
> > > +++ subversion/libsvn_ra_dav/fetch.c (Arbeitskopie)
> > > @@ -1578,7 +1578,7 @@
> > >
> > > /* ### Should svn_ra_dav__parsed_request() take care of storing auth
> > > ### info itself? */
> > > - SVN_ERR( svn_ra_dav__maybe_store_auth_info_after_result(err, ras) );
> > > + err = svn_ra_dav__maybe_store_auth_info_after_result(err, ras);
> > >
> > > if (baton.err)
> > > return baton.err;
> > >
>
> If baton.err != NULL, you leak err here if that too is not NULL.

But note that Steve *fixed* a bug (one that I wrote), whereby
baton.err was failing to dominate when it should dominate, because I
used SVN_ERR() too hastily. On trunk, there's code after the 'if'
above that takes care of the error leak, you just don't see that code
here because Steve's patch is against non-trunk code.

Ben Collins-Sussman is fixing this right now, basically using Steve's
patch, I believe. Then there will be a separate commit to fix the
regression against 1.1.x servers.

Steve, thanks!

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 18 22:17:44 2005

This is an archived mail posted to the Subversion Dev mailing list.