[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: REVIEW REQUESTED (was Re: Parseable tracking of code contributions.)

From: <kfogel_at_collab.net>
Date: 2005-07-16 18:56:29 CEST

Julian Foad <julianfoad@btopenworld.com> writes:
> All good as far as I can see from a browse through, except for
> trailing white space as noted below.
> For some unknown reason, it took me a while to get used to the change
> from "Based on a patch by X" to "Patch by: X [and] me", but it makes
> perfect sense.
> The removal of words like "Thanks to X for this patch" isn't a problem
> as such messages are better said on the mailing list.

Thanks for looking over the changes! Yeah, I tried not to lose real
information or real humor, but felt it was okay to transform common
idioms like that.

It's hard to tell from the diff, but a lot of messages actually got
rather more readable.

> > --- OLD/r10415 2005-07-16 00:17:17.000000000 -0500
> > +++ NEW/r10415 2005-07-16 00:17:18.000000000 -0500
> > @@ -1,6 +1,6 @@
> > Updates to Norwegian Bokmål message file.
> > -Patch from Øyvind A. Holm <sunny@sunbase.org>.
> > +Patch by: Øyvind A. Holm <sunny@sunbase.org>
> > * subversion/po/nb.po:
> > - Added a dictionary at the beginning with some common words used in the
> > @@ -9,3 +9,4 @@
> > string instead of using the "fuzzy" mark.
> > - "Innstikksmodul" (plugin) changed to "programtillegg".
> > - Many new messages.
> > +
> > =*= =*= =*= =*= =*=
> Here and in some other places you appear to add an extraneous blank
> line at the end. As well as avoiding that, you might as well make all
> of the log messages that you are touching end consistently, by
> removing trailing blank lines where present (and adding an end-of-line
> if it is missing, but it isn't missing in any of the revisions you are
> touching).

Whups! Yup, I know what happened, and will fix right away.

Actually, although the diff doesn't show it, this change mostly
regularizes our end-of-line situation. (It's very complicated to
explain why the diff doesn't show it, and I didn't think it was
important enough to be worth mentioning. What you're seeing above is
actually a place where I failed to do the regularization; for those
same complicated reasons, it shows up as a diff.)

Anyway, I've uploaded a new version now, take another look.



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 16 19:46:37 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.