[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn st -u regression with 1.1.x servers

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-07-16 19:10:09 CEST

SteveKing wrote:
> Ben Collins-Sussman wrote:
>
>>
>> On Jul 16, 2005, at 11:23 AM, SteveKing wrote:
>>
>>>
>>> Since 'svn st -u' is an important and often used feature, I agree.
>>> (I'm just wondering why noone else noticed this before - maybe
>>> because all projects were already using an svn 1.2 server?)
>>>
>>
>> I see that my patch duplicates the same logic that I wrote for
>> svn_client_info(), so I'm pretty confident it's the Right Thing.
>> I've committed it to trunk, and nominated for svn 1.2.2.
>>
>> Still, I wonder if our regression tests never test 'svn status -u'?
>> I seem to recall testing a 1.2 client against a 1.1 server...
>
>
> I've applied your patch to my Subversion 1.2.1 working copy and
> compiled. But I still see the same error!?!
> I'll investigate further, stay tuned...

Ok, so here's what I found so far:

In the line before your patch, svn_ra_get_locks() is called which
returns the error code 175002. According to the svn_error_codes.h file,
this would be SVN_ERR_RA_DAV_REQUEST_FAILED.

So I stepped into svn_ra_get_locks(), then svn_ra_dav__parsed_request().

libsvn_ra_dav/util.c, line 722:

   if ((code != expected_code)
       || (rv != NE_OK))

here, code is 501, and rv is zero. So a few lines below,
svn_ra_dav__convert_error() is called with rv=0 which makes it just
return the default error code SVN_ERR_RA_DAV_REQUEST_FAILED.

So your patch fails because SVN_ERR_RA_DAV_REQUEST_FAILED is returned,
not SVN_ERR_UNSUPPORTED_FEATURE.

Don't know why that happens though, I'm not too familiar with the
Subversion internals :(

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 16 19:10:46 2005

This is an archived mail posted to the Subversion Dev mailing list.