[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: REVIEW REQUESTED (was Re: Parseable tracking of code contributions.)

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-07-16 18:36:29 CEST

kfogel@collab.net wrote:
> I've got all the log message changes ready now. Please review
> http://www.red-bean.com/kfogel/changed-revs.utf8
> I also took the opportunity to clean up other things in the affected
> log messages

All good as far as I can see from a browse through, except for trailing white
space as noted below.

For some unknown reason, it took me a while to get used to the change from
"Based on a patch by X" to "Patch by: X [and] me", but it makes perfect sense.

The removal of words like "Thanks to X for this patch" isn't a problem as such
messages are better said on the mailing list.

> --- OLD/r10415 2005-07-16 00:17:17.000000000 -0500
> +++ NEW/r10415 2005-07-16 00:17:18.000000000 -0500
> @@ -1,6 +1,6 @@
> Updates to Norwegian Bokmål message file.
> -Patch from Øyvind A. Holm <sunny@sunbase.org>.
> +Patch by: Øyvind A. Holm <sunny@sunbase.org>
> * subversion/po/nb.po:
> - Added a dictionary at the beginning with some common words used in the
> @@ -9,3 +9,4 @@
> string instead of using the "fuzzy" mark.
> - "Innstikksmodul" (plugin) changed to "programtillegg".
> - Many new messages.
> +
> =*= =*= =*= =*= =*=

Here and in some other places you appear to add an extraneous blank line at the
end. As well as avoiding that, you might as well make all of the log messages
that you are touching end consistently, by removing trailing blank lines where
present (and adding an end-of-line if it is missing, but it isn't missing in
any of the revisions you are touching).

You should also remove trailing white space from at least the lines you touched
(those starting with "+" in the diff).

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 16 18:37:12 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.