[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

REVIEW REQUESTED (was Re: Parseable tracking of code contributions.)

From: <kfogel_at_collab.net>
Date: 2005-07-16 06:58:17 CEST

I've got all the log message changes ready now. Please review


The arrangement is pretty simple. We've got three fields:

   Patch by: ## The named person(s) submitted this patch.
   Review by: ## The named person(s) reviewed this change.
   Suggested by: ## The named person(s) suggested/inspired this change.

A field starts at the beginning of a line. A field can hold multiple
people, one per line (a continuation line follows the previous line
immediately, and starts with whitespace). I'll write all this up for
HACKING, of course; this is just a summary.

Those three categories covered the vast majority of changes that
involved contributors other than the committer, in which the
contribution was one that would be relevant in evaluating someone for
commit access. Remember, eyes on the prize: the purpose of all this
is to help us spot new developers more efficiently. Everything was
done with that in mind; there were plenty of edge cases, but they were
usually easily resolvable when I kept the overall goal in mind.

In maybe four places I used "Contribution by: ", for contributions
that were not exactly patches; but that was so rare, I think I won't
even bother to document it in HACKING. (It's still useful because it
makes them easy to find later, since they follow the informal
convention of "SOMEWORD by: " at the beginning of a line.)

I also took the opportunity to clean up other things in the affected
log messages -- made people's names consistent, put the caron in
Branko's name everywhere, fixed up revision syntax, stuff like that.
Please don't reflexively cry "But that's mixing unrelated changes!"
These are revprop changes: they're not versioned, the meta-change has
no log message of its own, and in general there's no reason to treat
them like normal changes.

I'll hold off on doing the propsets until I hear some feedback.

There will be 981 revprop-set mails when I run this. If anyone wants
a warning posted here first, so they can temporarily unsubscribe from
the commits list, let me know.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 16 07:48:19 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.