[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Trivial patches?

From: Gareth McCaughan <gareth.mccaughan_at_pobox.com>
Date: 2005-07-11 01:56:00 CEST

On Monday 11 July 2005 00:15, Mark Benedetto King wrote:
> On Sun, Jul 10, 2005 at 01:22:39AM +0100, Gareth McCaughan wrote:
> > Karl Fogel wrote:
> > > Careful, those are two different practices there.
> > >
> > > Yes, a patch should be about one thing, and not include unrelated
> > > changes.
> > >
> > > No, a patch for a 1 character typo is not necessarily worth the time.
> >
> > (Context suggests that "necessarily" could be replaced with
> > "ever, except perhaps in a few exceptional cases".)
>
> Actually, it happens quite a bit.

Ah, but the question is whether it *should*, and (perhaps wrongly)
I took Karl to be saying that usually it shouldn't. And, um,
I hope it was obvious that I wasn't being altogether serious...

-- 
g
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 11 01:56:48 2005

This is an archived mail posted to the Subversion Dev mailing list.