[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Trivial patches?

From: <kfogel_at_collab.net>
Date: 2005-07-11 17:37:45 CEST

Gareth McCaughan <gareth.mccaughan@pobox.com> writes:
> Karl Fogel wrote:
> > Careful, those are two different practices there.
> > Yes, a patch should be about one thing, and not include unrelated changes.
> > No, a patch for a 1 character typo is not necessarily worth the time.
>
> (Context suggests that "necessarily" could be replaced with
> "ever, except perhaps in a few exceptional cases".)

Yes, that's what I meant.

> Corollary: No single-character typo will ever be fixed,
> unless something else in the same vicinity requires changing.
>
> Further corollary: Comments in Subversion's source code
> will, over time, approach a state where the density of
> single-character typos is just barely low enough that
> no patch small and local enough to be "about one thing"
> fixes enough of them to be worth while.
>
> Remark: That would suck.
>
> Perhaps when it reaches this state someone will make
> a single patch that fixes hundreds of little typos, and
> that can be considered to be "about one thing", namely
> fixing typos.
>
> :-)

Yes, I think that chain of logic is reasonable :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 11 18:31:32 2005

This is an archived mail posted to the Subversion Dev mailing list.