[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Move authz access control to libsvn_repos

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-07-03 06:20:46 CEST

On Sat, 2005-07-02 at 16:55 -0400, Greg Hudson wrote:
> Here's what I found:
>
> 1. You're using tabs. We don't use tabs in the Subversion code base
> (at least not in the C code).
>
> 2. The access types enum should be in svn_repos.h, not svn_types.h.
> There's no rule that says all types are defined in svn_types.h, despite
> the name.
>
> 3. I'm dubious about AUTHZ_ACCESS_GRANTED and AUTHZ_ACCESS_DETERMINED
> being defined as macros. You can't debug into a macro, so defining big
> macros tends to reduce our code's maintainability.

While i agree as a general principle (I hate most macros that are
anything more than constant values or hiding ugly casting), i should
note that these days, you can debug into a macro, *and* print it's value
when called with a given parameter.
You just need to use -g3 to compile, and a new enough gdb (it was added
somewhere in the 6.x line. I did the gcc work back in the 3.3 or 3.4
series, IIRC).

:)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 3 06:21:47 2005

This is an archived mail posted to the Subversion Dev mailing list.