Re: svn commit: r14898 - in trunk/subversion: tests/clients/cmdline

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> On Wed, 1 Jun 2005, Philip Martin wrote:
>
>> lundblad@tigris.org writes:
>
>> > +
>> > +
>> > + svntest.actions.run_and_verify_svn(None, None, None, 'unlock',
>> > + '--username', svntest.main.wc_author,
>> > + '--password', svntest.main.wc_passwd,
>> > + file_path)
>>
>> This doesn't verify that the lock got released.
>>
>>
> But it verifies that there was no error output. Ain't that enough?

Not really. A recent change caused 'svn unlock URL' to SEGV and the
the test using it still passed. As it happens the SEGV occurred after
the lock was removed, but if it had happened before the lock was
removed the test would still have passed.

> (BTW, looking at the break_lock test, that might have the same
> problem)?

Very likely, lots of the locking tests have similar problems.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org